Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#7418: Rename internal interchange protocol methods. #7422

Merged
merged 2 commits into from
Jan 16, 2025
Merged

REFACTOR-#7418: Rename internal interchange protocol methods. #7422

merged 2 commits into from
Jan 16, 2025

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Jan 16, 2025 •
edited
Loading

What do these changes do?

Rename internal to_dataframe methods to to_interchange_dataframe, and internal from_dataframe methods to from_interchange_dataframe.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Query compiler method to_dataframe should be named to_interchange or similar #7418
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@sfc-gh-mvashishtha
REFACTOR-modin-project#7418: Rename to_dataframe to to_interchange_da…
0e57d6b 
…taframe.

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review January 16, 2025 06:47
@sfc-gh-mvashishtha
Rename internal from_dataframe methods to from_interchange_dataframe
fb6bba7 
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-mvashishtha sfc-gh-mvashishtha changed the title REFACTOR-#7418: Rename to_dataframe to to_interchange_dataframe. REFACTOR-#7418: Rename internal interchange protocol methods. Jan 16, 2025
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 4cae985 into modin-project:main Jan 16, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@anmyachev anmyachev anmyachev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query compiler method to_dataframe should be named to_interchange or similar
3 participants
@sfc-gh-mvashishtha @anmyachev @sfc-gh-joshi